Feathers: add override cursor #21824
Open
+36
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossleonardy
suggested changes
Nov 14, 2025
PPakalns
reviewed
Nov 15, 2025
Contributor
PPakalns
left a comment
PPakalns
left a comment
There was a problem hiding this comment.
Locally tested. Functionality works.
PPakalns
suggested changes
Nov 15, 2025
PPakalns
suggested changes
Nov 15, 2025
Contributor
PPakalns
left a comment
PPakalns
left a comment
There was a problem hiding this comment.
Last minor comments. Overall looks good :)
rossleonardy
suggested changes
Nov 15, 2025
PPakalns
approved these changes
Nov 15, 2025
rossleonardy
approved these changes
Nov 15, 2025
alice-i-cecile
added
C-Feature
Member
|
Did you mean to close this by deleting the branch? |
Contributor
Author
|
Nope... didn't realize it wasn't merged yet. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21801 and tweaks the feathers example to exhibit the new behavior.
Solution
What the issue suggested. Added a new resource and adjusted the
EntityCursorinteraction logic incursor.rs.Testing
Tested it via the example tweak where the wide button now toggles the override logic.
(Note: I wasn't able to get the load cursor to show up on macOS, but I think this is a
winitissue:cursorbusyButClickableCursorappears to be invalid)